On 08/09/2012 10:41 AM, Janne Grunau wrote:
> On 2012-08-09 07:47:12 +0200, Luca Barbato wrote:
>> On 08/09/2012 02:03 AM, Nathan Caldwell wrote:
>>> From: Hendrik Leppkes <[email protected]>
>>>
>>> About 2x speedup going from 1 to 2 threads.
>>> 1.7s to 0.85s on foreman CIF.
>>> ---
>>>  libavcodec/lagarith.c |   15 ++++++++-------
>>>  1 files changed, 8 insertions(+), 7 deletions(-)
>>>
>>
>> Looks ok beside the missing ff_thread_finish_setup()
> 
> it's not strictly missing. For simple codecs which don't need
> to update the next thread context while decoding it's implicitly
> called from our threading code.
> 
> We can argue wheter we want to make it explicit if even Ronald
> is not fully aware of the implicit calls. But it doesn't make
> much sense having each multithreaded decoder which don't need
> to call ff_thread_finish_setup() call it first in it's decode
> function.

Fine for me.

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to