Luca Barbato <[email protected]> writes:

> On 09/24/2012 12:09 AM, Måns Rullgård wrote:
>> Jordi Ortiz <[email protected]> writes:
>> 
>>> ---
>>>  libavcodec/dsputil.c |   85 
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  libavcodec/dsputil.h |   36 +++++++++++++++++++++
>>>  2 files changed, 121 insertions(+)
>>>
>>> diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
>>> index 5c705ea..39360c5 100644
>>> --- a/libavcodec/dsputil.c
>>> +++ b/libavcodec/dsputil.c
>>> @@ -2998,3 +2998,88 @@ av_cold void ff_dsputil_init(DSPContext* c, 
>>> AVCodecContext *avctx)
>>>      ff_init_scantable_permutation(c->idct_permutation,
>>>                                    c->idct_permutation_type);
>>>  }
>>> +
>>> +#if CONFIG_DIRAC_DECODER
>>> +void ff_put_pixels8_8_c(uint8_t *dst, const uint8_t *src, int stride, int 
>>> h)
>>> +{
>>> +    put_pixels8_8_c(dst, src, stride, h);
>>> +}
>> 
>> Do not add codec-specific things to dsputil.c.  No exceptions.
>> 
>> Whatever reason you have for this, there is a better solution.
>> 
> a possibility is tear away put_pixels* in a separate file I guess.

Why can't dirac call the function pointers in DSPContext like everything
else?

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to