On Fri, Sep 28, 2012 at 02:42:31PM -0600, Nathan Caldwell wrote: > On Fri, Sep 28, 2012 at 8:20 AM, Diego Biurrun <[email protected]> wrote: > > From: Nathan Caldwell <[email protected]> > > > > Signed-off-by: Diego Biurrun <[email protected]> > > --- > > Now with missing multiple inclusion guards and shared function in a .c file. > > > > --- /dev/null > > +++ b/libavcodec/libopus.c > > @@ -0,0 +1,47 @@ > > + > > +#include <opus_defines.h> > > + > > +#include "libavutil/error.h" > > +#include "libopus.h" > > This needs to include libavutil/common.h for MKTAG (via AVERROR). > > libavutil/common.h can probably be removed from the encoder (maybe the > decoder as well?), although it doesn't hurt leaving it there.
The file does not use MKTAG ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
