On Sat, 29 Sep 2012 21:59:17 +0200, Luca Barbato <[email protected]> wrote: > On 09/28/2012 07:58 PM, Anton Khirnov wrote: > > > > On Fri, 28 Sep 2012 10:22:39 -0700, Josh Allmann <[email protected]> > > wrote: > >> > >> Will this be used in other places? But OK since it makes the code > >> easier to read. > >> > >> Generally the rest looks good, but I wonder if the mechanical/cosmetic > >> changes could be patched separately from the actual splitting, to make > >> a patch of this size easier to reason about. > >> > > > > +1, please split that into two patches. > > It is a boring and long work for no purpose...
The purpose is to make this patch reviewable. Mixing trivial moves and nontrivial changes, especially in a patch this size makes it unnecessarily harder and more annoying to review. Please avoid this in the future. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
