On 10/24/2012 06:02 AM, Luca Barbato wrote: > On 10/23/12 11:43 PM, Justin Ruggles wrote: >> Ensures the decoder did not set channel count to an insanely high value >> during initialization, which could cause large memory usage when it >> tries to >> get a buffer during decoding. >> --- >> libavcodec/utils.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> > > I'd make it tunable (e.g. adding an -strict insane value for the cases > in which it is needed).
Why? If you're worried about cases where people might actually want that many channels to be decoded, we can increase the value. This is mainly for situations where the decoder reads channel count from extradata during init(). I'm not worried about 256 vs. 128 or whatever. I'm worried about channel counts in the hundreds-of-thousands or millions. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
