On Fri, Oct 19, 2012 at 06:57:25PM +0200, Diego Biurrun wrote: > On Wed, Apr 25, 2012 at 02:08:54PM +0100, Mans Rullgard wrote: > > This code spews a multitude of warnings with glibc (unchecked > > return values), some of them possibly warranted. Furthermore, > > the deamonisation is not suitable for use with typical startup > > scripts as it does not provide the PID of the daemon in any way. > > Users wishing to run avserver as a daemon can still do so using > > start-stop-daemon or equivalent tools. > > > > Signed-off-by: Mans Rullgard <[email protected]> > > --- > > avserver.c | 38 -------------------------------------- > > 1 file changed, 38 deletions(-) > > This is missing changes to the documentation, which mentions the > daemon mode.
Note that I don't have much of an opinion about the patch itself, but I'm surely not opposed to removing broken code. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
