Janne Grunau <[email protected]> writes:

> ---
>  avserver.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/avserver.c b/avserver.c
> index 8bc6b3c..d6e3478 100644
> --- a/avserver.c
> +++ b/avserver.c
> @@ -25,6 +25,7 @@
>  #endif
>  #include <string.h>
>  #include <stdlib.h>
> +#include <stdio.h>
>  #include "libavformat/avformat.h"
>  // FIXME those are internal headers, avserver _really_ shouldn't use them
>  #include "libavformat/ffm.h"
> @@ -513,13 +514,12 @@ static void start_children(FFStream *feed)
>                      close(i);
>  
>                  if (!avserver_debug) {
> -                    i = open("/dev/null", O_RDWR);
> -                    if (i != -1) {
> -                        dup2(i, 0);
> -                        dup2(i, 1);
> -                        dup2(i, 2);
> -                        close(i);
> -                    }
> +                    if (!freopen("/dev/null", "r", stdin))
> +                        http_log("failed to redirect STDIN to /dev/null\n;");
> +                    if (!freopen("/dev/null", "w", stdout))
> +                        http_log("failed to redirect STDOUT to 
> /dev/null\n;");
> +                    if (!freopen("/dev/null", "w", stderr))
> +                        http_log("failed to redirect STDERR to 
> /dev/null\n;");
>                  }
>  
>                  signal(SIGPIPE, SIG_DFL);
> -- 

LGTM

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to