On Mon, Dec 03, 2012 at 10:29:38AM +0100, Janne Grunau wrote: > On 2012-11-28 18:18:17 +0100, Diego Biurrun wrote: > > --- a/tests/fate/bmp.mak > > +++ b/tests/fate/bmp.mak > > @@ -37,5 +37,7 @@ fate-bmp-rle4: CMD = framecrc -i > > $(SAMPLES)/bmp/testcompress4.bmp -pix_fmt rgb24 > > > > -FATE_SAMPLES_AVCONV += $(FATE_BMP) > > -fate-bmp: $(FATE_BMP) > > +FATE_BMP-$(call DEMDEC, IMAGE2, BMP) += $(FATE_BMP) > > + > > +FATE_SAMPLES_AVCONV += $(FATE_BMP-yes) > > +fate-bmp: $(FATE_BMP-yes) > > --- a/tests/fate/cdxl.mak > > +++ b/tests/fate/cdxl.mak > > @@ -13,5 +13,7 @@ fate-cdxl-pal8-small: CMD = framecrc -i > > $(SAMPLES)/cdxl/fruit.cdxl -an -pix_fmt > > > > -FATE_SAMPLES_AVCONV += $(FATE_CDXL) > > -fate-cdxl: $(FATE_CDXL) > > +FATE_CDXL-$(call DEMDEC, CDXL, CDXL) += $(FATE_CDXL) > > + > > +FATE_SAMPLES_AVCONV += $(FATE_CDXL-yes) > > +fate-cdxl: $(FATE_CDXL-yes) > > --- a/tests/fate/dfa.mak > > +++ b/tests/fate/dfa.mak > > @@ -31,5 +31,7 @@ fate-dfa10: CMD = framecrc -i > > $(SAMPLES)/chronomaster-dfa/0009.dfa -pix_fmt rgb2 > > > > -FATE_SAMPLES_AVCONV += $(FATE_DFA) > > -fate-dfa: $(FATE_DFA) > > +FATE_DFA-$(call DEMDEC, DFA, DFA) += $(FATE_DFA) > > + > > +FATE_SAMPLES_AVCONV += $(FATE_DFA-yes) > > +fate-dfa: $(FATE_DFA-yes) > > --- a/tests/fate/flac.mak > > +++ b/tests/fate/flac.mak > > @@ -22,5 +22,5 @@ fate-flac-24-%: CMD = enc_dec_pcm flac wav s24le $(REF) > > -c flac $(OPTS) > > -FATE_SAMPLES_AVCONV += $(FATE_FLAC) > > +FATE_SAMPLES_AVCONV-$(call ENCDEC, FLAC, FLAC) += $(FATE_FLAC) > > fate-flac: $(FATE_FLAC) > > Any reason why you're handling flac differently? I don't care either way > just wondering about the inconsistancy. > > Ok with me but please decide how to handle sub-targets with all disabled > tests.
The topic came up before, no decision was made either way. I would suggest disabling subtargets with (all) tests disabled, i.e. only add enabled tests to those targets and if the set of enabled tests is empty, add none and let the target fail. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
