Hi, On Sat, Jan 19, 2013 at 1:05 PM, Diego Biurrun <[email protected]> wrote: > On Sat, Jan 19, 2013 at 12:48:43PM -0800, Ronald S. Bultje wrote: >> >> --- a/tests/fate-run.sh >> +++ b/tests/fate-run.sh >> @@ -128,6 +128,7 @@ enc_dec(){ >> dec_fmt=$5 >> dec_opt=$6 >> + ddc_opt=$8 >> encfile="${outdir}/${test}.${enc_fmt}" >> decfile="${outdir}/${test}.out.${dec_fmt}" >> @@ -139,7 +140,7 @@ enc_dec(){ >> do_md5sum $encfile >> echo $(wc -c $encfile) >> - avconv $DEC_OPTS -i $tencfile $ENC_OPTS $dec_opt $FLAGS \ >> + avconv $DEC_OPTS $ddc_opt -i $tencfile $ENC_OPTS $dec_opt $FLAGS \ >> -f $dec_fmt -y $tdecfile || return >> do_md5sum $decfile >> --- a/tests/fate/vcodec.mak >> +++ b/tests/fate/vcodec.mak >> @@ -2,7 +2,7 @@ fate-vsynth1-%: SRC = tests/data/vsynth1.yuv >> fate-vsynth%: CODEC = $(word 3, $(subst -, ,$(@))) >> fate-vsynth%: FMT = avi >> -fate-vsynth%: CMD = enc_dec "rawvideo -s 352x288 -pix_fmt yuv420p" $(SRC) >> $(FMT) "-c $(CODEC) $(ENCOPTS)" rawvideo "-s 352x288 -pix_fmt yuv420p >> $(DECOPTS)" -keep >> +fate-vsynth%: CMD = enc_dec "rawvideo -s 352x288 -pix_fmt yuv420p" $(SRC) >> $(FMT) "-c $(CODEC) $(ENCOPTS)" rawvideo "-s 352x288 -pix_fmt yuv420p >> $(DECOPTS)" -keep "$(DDCOPTS)" >> fate-vsynth%: CMP_UNIT = 1 >> fate-vsynth%: REF = $(SRC_PATH)/tests/ref/vsynth/$(@:fate-%=%) >> >> @@ -218,7 +218,8 @@ FATE_VCODEC-$(call ENCDEC, WMV1, AVI) += wmv1 >> fate-vsynth%-wmv1: ENCOPTS = -qscale 10 >> >> FATE_VCODEC-$(call ENCDEC, WMV2, AVI) += wmv2 >> -fate-vsynth%-wmv2: ENCOPTS = -qscale 10 >> +fate-vsynth%-wmv2: DDCOPTS = -idct auto >> +fate-vsynth%-wmv2: ENCOPTS = -qscale 10 -idct auto > > Why not skip all of this and add "-idct auto" to DECOPTS?
That's not added to all steps in enc_dec(). All of this is undone anyway in patch #2, so please don't worry too much. Again: THIS PROVES THAT THE CHANGES TO THE FATE RESULT ARE CORRECT ALL CHANGES IN THIS PATCH EXCEPT THE FATE REF CHANGES ARE UNDONE IN PATCH 2 Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
