Hi, On Sat, Jan 19, 2013 at 1:25 PM, Diego Biurrun <[email protected]> wrote: > On Sat, Jan 19, 2013 at 12:48:44PM -0800, Ronald S. Bultje wrote: >> --- a/libavcodec/Makefile >> +++ b/libavcodec/Makefile >> @@ -410,10 +410,10 @@ OBJS-$(CONFIG_WMAVOICE_DECODER) += wmavoice.o \ >> OBJS-$(CONFIG_WMV1_DECODER) += msmpeg4.o msmpeg4data.o >> -OBJS-$(CONFIG_WMV2_DECODER) += wmv2dec.o wmv2.o \ >> +OBJS-$(CONFIG_WMV2_DECODER) += wmv2dec.o wmv2.o wmv2dsp.o \ >> msmpeg4.o msmpeg4data.o \ >> intrax8.o intrax8dsp.o >> -OBJS-$(CONFIG_WMV2_ENCODER) += wmv2enc.o wmv2.o \ >> +OBJS-$(CONFIG_WMV2_ENCODER) += wmv2enc.o wmv2.o wmv2dsp.o \ >> msmpeg4.o msmpeg4enc.o >> msmpeg4data.o \ >> mpeg4videodec.o ituh263dec.o >> h263dec.o > > vc1 and mss2 also use this, so I expect this patch to break their standalone > compilation. Introduce a wmv2dsp variable in configure, have the decoders > that need it _depend on it and compile wmw2dsp conditional to that variable.
No, they don't need it. If they do, somebody messed up before me. vc1 and mss2 do not use the wmv2 idct. >> --- /dev/null >> +++ b/libavcodec/wmv2dsp.c >> @@ -0,0 +1,141 @@ >> +/* >> + * Copyright (C) 2004 the ffmpeg project >> + * >> + * This file is part of Libav. >> + * >> + */ >> + >> +/** >> + * @file >> + * Standard C DSP-oriented functions cribbed from the original VP3 >> + * source code. >> + */ > > This looks misplaced, seems to come from vp3, so i guess you copy-pasted > the wrong file. Will fix. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
