Hi, On Sun, Jan 20, 2013 at 9:03 AM, Diego Biurrun <[email protected]> wrote: > On Sat, Jan 19, 2013 at 01:52:24PM -0800, Ronald S. Bultje wrote: >> --- a/libavcodec/dsputil.c >> +++ b/libavcodec/dsputil.c >> @@ -2488,90 +2488,6 @@ static void vector_clip_int32_c(int32_t *dst, const >> int32_t *src, int32_t min, >> >> -void ff_wmv2_idct_c(short * block){ > > You have removed this function, but the matching declaration in > dsputil.h is left behind. > >> --- /dev/null >> +++ b/libavcodec/wmv2dsp.c >> @@ -0,0 +1,135 @@ >> +/* >> + * Copyright (C) 2004 the ffmpeg project >> + * >> + * This file is part of Libav. > > This copyright line is bogus; I suggest dropping it.
Both fixed locally. > The patch does LGTM, but I think 1/3 and 2/3 should be squashed. Can someone review patch 1 then? I don't mind squashing them (in fact, I agree with it) but do want a review on that patch also. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
