On Wed, 10 Apr 2013, Kostya Shishkov wrote:
On Wed, Apr 10, 2013 at 12:37:02PM +0300, Martin Storsjö wrote:
From: "Ronald S. Bultje" <[email protected]>
---
libavcodec/x86/dsputil_mmx.c | 3 ---
libavcodec/x86/dsputil_mmx.h | 3 ---
libavcodec/x86/vp3dsp.asm | 7 ++++---
3 files changed, 4 insertions(+), 9 deletions(-)
I'd say "move constants to the only place where they are used" but that's me.
Changed locally
The patch looks OK
diff --git a/libavcodec/x86/vp3dsp.asm b/libavcodec/x86/vp3dsp.asm
index 9ea9cca..adda822 100644
--- a/libavcodec/x86/vp3dsp.asm
+++ b/libavcodec/x86/vp3dsp.asm
@@ -33,12 +33,13 @@ vp3_idct_data: times 8 dw 64277
times 8 dw 25080
times 8 dw 12785
+pb_7: times 8 db 7
+pb_1F: times 8 db 0x1f
+pb_81: times 8 db 0x81
a bit of vertical alignment maybe?
Fixed locally as well
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
