On Wed, 10 Apr 2013, Diego Biurrun wrote:

On Wed, Apr 10, 2013 at 11:52:31AM +0300, Martin Storsjö wrote:
--- /dev/null
+++ b/libavcodec/hpeldsp.c
@@ -0,0 +1,56 @@
+
+#include "libavutil/attributes.h"
+#include "libavutil/intreadwrite.h"
+#include "hpeldsp.h"
+
+#define BIT_DEPTH 8
+#include "hpeldsp_template.c"
+
+av_cold void ff_hpeldsp_init(HpelDSPContext* c, int flags)

*c

Fixed locally

The flags parameter is unused.

Explained by Kostya

--- /dev/null
+++ b/libavcodec/hpeldsp.h
@@ -0,0 +1,97 @@
+
+/* add and put pixel (decoding) */
+// blocksizes for op_pixels_func are 8x4,8x8 16x8 16x16
+// h for op_pixels_func is limited to {width/2, width} but never larger
+// than 16 and never smaller than 4

This mix of comment types looks weird.

Yes, it's a copy of the same lines from dsputil.h

+void ff_hpeldsp_init(HpelDSPContext* p, int flags);

*p

or *c like in the .c file ..

Fixed

--- /dev/null
+++ b/libavcodec/hpeldsp_template.c

Is this a copy of some other file?  Then git should detect this if you
have the right settings in your gitconfig.

Will do.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to