On Wed, 10 Apr 2013, Justin Ruggles wrote:
On 04/09/2013 06:57 PM, Christophe Gisquet wrote:
This patch can be controversial, by assuming floats are IEEE-754 and
particular behaviour of the FPU will get in the way.
Timing on Arrandale and Win32 (thus, x87 FPU is used in the reference).
sbr_qmf_pre_shuffle_c: 115 to 76
sbr_neg_odd_64_c: 84 to 55
sbr_qmf_post_shuffle_c: 112 to 83
---
libavcodec/sbrdsp.c | 50 +++++++++++++++++++++++++++++++++-----------------
1 file changed, 33 insertions(+), 17 deletions(-)
[...]
I'm generally ok with the patch. I'm pretty sure Libav won't work on
non-IEEE-754 due to assumptions being made in other places as well. It
seems safe enough to me. Maybe others disagree though?
I'm ok with it - similar optimizations are done elsewhere as well.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
