On Tue, 30 Apr 2013 07:34:39 +0200, Luca Barbato <[email protected]> wrote:
> On 04/11/2013 09:10 PM, Anton Khirnov wrote:
> > This makes output -ss sample-accurate for audio and will allow further
> > simplication in the future.
> > @@ -183,7 +183,7 @@ static int insert_trim(OutputStream *ost, 
> > AVFilterContext **last_filter, int *pa
> >      char filter_name[128];
> >      int ret = 0;
> >  
> > -    if (of->recording_time == INT64_MAX)
> > +    if (of->recording_time == INT64_MAX && !of->start_time)
> >          return 0;
> 
> ...
> 
> > +    if (of->recording_time != INT64_MAX) {
> > +        ret = av_opt_set_double(ctx, "duration", 
> > (double)of->recording_time / 1e6,
> > +                                AV_OPT_SEARCH_CHILDREN);
> > +    }
> > +    if (ret >= 0 && of->start_time) {
> > +        ret = av_opt_set_double(ctx, "start", (double)of->start_time / 1e6,
> > +                                AV_OPT_SEARCH_CHILDREN);
> > +    }
> 
> why the duplicated check? (If I read the patch correctly)
> 

What duplicated check?

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to