On 2013-05-21 09:42:59 +0300, Martin Storsjö wrote:
> On Tue, 21 May 2013, Diego Biurrun wrote:
> 
> > On 05/20/2013 10:33 AM, Martin Storsjö wrote:
> >> If building out of tree, make sure the filter scripts are copied
> >> into the build tree before running tests. This makes sure that
> >> SRC_PATH doesn't need to exist on the remote system (or doesn't
> >> need to exist at the same path).
> >> ---
> >>   tests/Makefile              |   10 ++++++++--
> >>   tests/fate/filter-audio.mak |    3 ++-
> >>   tests/fate/filter-video.mak |    6 ++++--
> >>   3 files changed, 14 insertions(+), 5 deletions(-)
> >
> > I don't have on opinion on this patch yet, but ..
> >
> >> --- a/tests/Makefile
> >> +++ b/tests/Makefile
> >> @@ -145,7 +151,7 @@ lcov-reset:
> >>
> >>   testclean:
> >> -  $(RM) -r tests/vsynth1 tests/data
> >> +  $(RM) -r tests/vsynth1 tests/data tests/filtergraphs
> >
> > .. this might be run in the source tree.  If somebody has changes in that 
> > directory, that person might be tempted to take you out in the yard and 
> > beat 
> > you up ;-p
> 
> Right - any suggestion on how to clean up this directory, only if building 
> out of tree?

always copying to a different directory and clean that is probably the
simplest robust solution

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to