On 2013-05-23 08:38:22 +0200, Diego Biurrun wrote:
> On 05/22/2013 11:34 AM, Martin Storsjö wrote:
> > On Wed, 22 May 2013, Martin Storsjö wrote:
> >>
> >> This probably works pretty well, and I'm ok with it. Another target
> >> that might be worth adding here is fate-rsync - iirc Janne had a setup
> >> where he ran make fate-rsync on a not-reconfigured setup somewhere
> >> that, started failing for this reason.
> >
> > "make clean" is another one you might want to run without having all the
> > deps in place. Yes it might not remove all the exact right files if
> > you've updated the code tree compared to when the files were built, but
> > you might still want to call it.
> 
> I thought about it already while constructing the patch.  Probably it 
> would be better to do it the other way around and only check when 
> actually running a fate- target.  To avoid checking during fate-rsync, 
> that could be renamed.

Missing config variables for components result already in build failures
so I don't think it is necessary to exempt CHKCFG for all but fate make
targets. The missing config variable error is easier to understand than
a build error and we could add a 'run make config' to the error message
as instruction how to fix it.

Letting the targets clean, config, distclean and fate-rsync succeed is
enough.

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to