On 09/09/13 17:09, Vittorio Giovara wrote:
> On Mon, Sep 9, 2013 at 4:42 PM, Vittorio Giovara
> <[email protected]> wrote:
>> On Mon, Sep 9, 2013 at 3:41 PM, Hendrik Leppkes <[email protected]> wrote:
>>> On Mon, Sep 9, 2013 at 3:37 PM, Vittorio Giovara <[email protected]
>>>> wrote:
>>>
>>>> ---
>>>> I performed some more benchmarking and the results at higher bitrates show
>>>> that the current implementation is better (by a tiny amount anyway). So I
>>>> rebased and reimplemented my change just as code simplification, without
>>>> modifying the inline attribute of the internal function.
>>>>
>>>> Cheers,
>>>>     Vittorio
>>>>
>>>>  libavcodec/mpeg12enc.c |    9 +++------
>>>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>>>
> 
> I misunderstood how the code worked here and the benefits of inlining
> against codesize.
> Sorry for the noise and thanks for the explanation on IRC.
> Patch dropped.

You said that the performance is unchanged so maybe it is worth checking
exactly how many branches we are trading.

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to