On Thu, 19 Sep 2013, Vittorio Giovara wrote:
I spent some time playing with include-what-you-use clang tool and found that
libav headers could benefit from removing a few unused headers.
So I propose a first set of patches that modify which headers are included and
in what order, specifically:
1. make sure there is a line between copyright header and the first include
2. include system headers first
3. include headers from the same library
4. include headers from other libav libraries
5. incldue headers from other libraries
6. any other ifdef library
I'm not sure this order is the best one, especially if we are making
things consistent. I'd rather have other libav libraries and other
libraries before the local library headers. The same reason and logic that
says system headers should be included first also applies in the same way
for the libraries and their interdependencies. So it would be better to
order them e.g. system headers, libavutil, libavcodec, libavformat or
something like that.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
