On Thu, Sep 19, 2013 at 3:36 PM, Diego Biurrun <[email protected]> wrote: > On Thu, Sep 19, 2013 at 10:26:34AM +0200, Vittorio Giovara wrote: >> So I propose a first set of patches that modify which headers are >> included and in what order, specifically: >> >> 1. make sure there is a line between copyright header and the first include >> 2. include system headers first >> 3. include headers from the same library >> 4. include headers from other libav libraries >> 5. incldue headers from other libraries >> 6. any other ifdef library >> 7. make sure there ia a line between the last include or ifdef and the code >> 8. move any non-doxygen comment before the include, if applicable > > Ifdeffed system headers should also be placed before libav headers. > You just have to #include config.h first in that case. >
Ok so, the order should be 1. make sure there is a line between copyright header and the first include 2. include system headers first 3. include "config.h" 4. any other ifdef system library 5. include headers from other libav libraries 6. incldue headers from other libraries 7 any other ifdef library 8. include headers from the same library 9. make sure there ia a line between the last include or ifdef and the code And no reordering of comments, I'll just drop the cruft ones. Is that fine with everyone? >> I could only test this set on linux x86, so I would really appreciate >> help for the other platforms (or instructions for this). > > Try installing some cross-compilers. > Ok I'll also check building out of tree... Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
