On 10/2/2013 9:35 PM, Diego Biurrun wrote:
> I know it's a WIP, just in case: changelog, version bump, docs
It's just a PoC, so I didn't bother.
>
>> --- a/configure
>> +++ b/configure
>> @@ -3808,6 +3812,7 @@ enabled libwavpack && require libwavpack
>> wavpack/wavpack.h WavpackOpenFil
>> enabled libx264 && require libx264 x264.h x264_encoder_encode
>> -lx264 &&
>> { check_cpp_condition x264.h "X264_BUILD >=
>> 118" ||
>> die "ERROR: libx264 version must be >=
>> 0.118."; }
>> +enabled libx265 && require libx265 x265.h x265_encoder_encode
>> -lx265 -lstdc++
>
> gah, C++
We shouldn't have to add -lsdtc++ (yes I hate it too). Once they start:
1) Making shared libs.
2) Making a pkg-config file.
> more and more this feels like non-community bullshit, sorry
http://mailman.videolan.org/pipermail/x265-devel/2013-October/001135.html
Yeah, I noticed.
> system headers before local headers
Eh? I just randomly looked at 4 files, and the *all* have them
*after*.
> So they copy-pasted all the POSIX-incompatible _t type names from x264?
Yes.
>> + memset(&x265pic_out, 0, sizeof(x265pic_out));
>
> Replace with "{ 0 }" initialization.
I had it like this before, but clang complained:
CC libavcodec/libx265.o
libavcodec/libx265.c:131:36: warning: suggest braces around initialization of
subobject [-Wmissing-braces]
x265_picture_t x265pic_out = { 0 };
^
{}
1 warning generated.
- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
