On Thu, Oct 03, 2013 at 11:38:39AM +0100, Derek Buitenhuis wrote:
> On 10/2/2013 9:35 PM, Diego Biurrun wrote:
> >> --- a/configure
> >> +++ b/configure
> > more and more this feels like non-community bullshit, sorry
>
> http://mailman.videolan.org/pipermail/x265-devel/2013-October/001135.html
>
> Yeah, I noticed.
All my preconceptions confirmed :-/
> > system headers before local headers
>
> Eh? I just randomly looked at 4 files, and the *all* have them
> *after*.
There are plenty of examples of bad style; that's not an excuse to add
new ones. Local headers could contain #defines that affect the system
headers, so it's safer to place the system headers first.
Note that Vittorio is working on cleaning up header placement and order.
> > So they copy-pasted all the POSIX-incompatible _t type names from x264?
>
> Yes.
Wonderful. Let me guess - they won't change it even if someone told them?
> >> + memset(&x265pic_out, 0, sizeof(x265pic_out));
> >
> > Replace with "{ 0 }" initialization.
>
> I had it like this before, but clang complained:
>
> CC libavcodec/libx265.o
> libavcodec/libx265.c:131:36: warning: suggest braces around initialization of
> subobject [-Wmissing-braces]
> x265_picture_t x265pic_out = { 0 };
> ^
> {}
> 1 warning generated.
{ { 0 } }
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
