On Thu, Oct 17, 2013 at 04:12:35PM -0700, Alex Converse wrote:
> This does not include support for LD SBR, epTool, data resialiance, nor
resiLIEnce
> --- a/libavcodec/aacdec.c
> +++ b/libavcodec/aacdec.c
> @@ -779,6 +779,69 @@ static int decode_ga_specific_config(AACContext *ac,
> AVCodecContext *avctx,
> +
> + m4ac->ps = 0;
> + m4ac->sbr = 0;
nit: align
> + res_flags = get_bits(gb, 3);
> + if (res_flags) {
> + av_log(avctx, AV_LOG_ERROR,
> + "AAC data resilience not supported (flags %x)\n",
> + res_flags);
> + return AVERROR_PATCHWELCOME;
> + }
> +
> + if (get_bits1(gb)) { // ldSbrPresentFlag
> + av_log(avctx, AV_LOG_ERROR, "Low Delay SBR not supported\n");
> + return AVERROR_PATCHWELCOME;
> + }
> +
> + ep_config = get_bits(gb, 2);
> + if (ep_config) {
> + av_log(avctx, AV_LOG_ERROR,
> + "epConfig %d is not supported.\n",
> + ep_config);
> + return AVERROR_PATCHWELCOME;
> + }
These could all use avpriv_report_missing_feature().
> @@ -1068,22 +1136,25 @@ static void decode_ltp(LongTermPrediction *ltp,
> @@ -1750,9 +1823,15 @@ static int decode_ics(AACContext *ac,
> SingleChannelElement *sce,
>
> + eld_syntax = ac->oc[1].m4ac.object_type == AOT_ER_AAC_ELD;
> + er_syntax = ac->oc[1].m4ac.object_type == AOT_ER_AAC_LC ||
> + ac->oc[1].m4ac.object_type == AOT_ER_AAC_LTP ||
> + ac->oc[1].m4ac.object_type == AOT_ER_AAC_LD ||
> + ac->oc[1].m4ac.object_type == AOT_ER_AAC_ELD;
> +
There's trailing whitespace on the empty line.
You could align some = above if you felt like it.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
