> This does not include support for LD SBR, epTool, data resilience, nor
> the 960 transform family.
> ---
>  Changelog            |   1 +
>  libavcodec/aac.h     |   2 +-
>  libavcodec/aacdec.c  | 207 ++++++++++++++++++----
>  libavcodec/aactab.c  | 483 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/aactab.h  |   1 +
>  libavcodec/version.h |   2 +-
>  6 files changed, 661 insertions(+), 35 deletions(-)

[...]

> +    int aot = ac->oc[1].m4ac.object_type;
> +    if (aot != AOT_ER_AAC_ELD) {
> +        if (get_bits1(gb)) {
> +            av_log(ac->avctx, AV_LOG_ERROR, "Reserved bit set.\n");
> +            return AVERROR_INVALIDDATA;
> +        }

Unrelated to patch: Should this not be a warning in non-explode mode?


> +            if (aot == AOT_AAC_MAIN) {
>                  if (decode_prediction(ac, ics, gb)) {
>                      return AVERROR_INVALIDDATA;
>                  }

Unrelated to patch: No av_log?

Cosmetics aside, patch seem reasonable, though I am not
AAC expert.

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to