On Sun, Nov 03, 2013 at 12:54:27PM +0100, Peter B. wrote: > On 11/02/2013 10:36 PM, Luca Barbato wrote: > > Send over the patch with the ffv1.mak > > This is the first patch I've created with git, so I hope it's fine. > Feedback welcome. > > From 87480c959aca41c9cdbd98490aa9df1325b8ca87 Mon Sep 17 00:00:00 2001 > From: Peter B. <[email protected]> > Date: Sun, 3 Nov 2013 12:50:00 +0100 > Subject: [PATCH] - Added additional FFV1 tests. - Modified > "lossless-video.mak" to include "ffv1.mak".
I suggest a subject line like fate: Add FFV1 tests > --- /dev/null > +++ b/tests/fate/ffv1.mak > @@ -0,0 +1,284 @@ > +# ================================================ > +# FATE tests for FFV1 lossless video codec > +# ================================================ > +# @author: Peter Bubestinger > +# @date: 02.Nov.2013 This is unnecessary. > +DEC_SRC = $(TARGET_PATH)/tests/data/fate > + > +fate-ffv1-enc-%: CODEC = $(word 2, $(subst -, ,$(@))) > +fate-ffv1-enc-%: FMT = avi > +fate-ffv1-enc-%: SRC = tests/data/vsynth1.yuv > +fate-ffv1-enc-%: CMD = enc_dec "rawvideo -s 352x288 -pix_fmt yuv420p > $(RAWDECOPTS)" $(SRC) $(FMT) "-c $(CODEC) $(ENCOPTS)" rawvideo "-s 352x288 > -pix_fmt yuv420p -vsync 0 $(DECOPTS)" -keep "$(DECINOPTS)" > + > + > +FATE_FFV1_LEVEL1 = v1-defaults \ > + v1-gray \ > + v1-rgb32 \ > + v1-yuv410p \ > + v1-yuv411p \ > + v1-yuv420p \ > + v1-yuv422p \ > + v1-yuv444p \ > + v1-bgra \ > + v1-tff \ > + v1-bff \ Get rid of all the tabs. > +fate-ffv1-dec-v1-defaults: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-defaults.avi > +fate-ffv1-dec-v1-yuv410p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv410p.avi > +fate-ffv1-dec-v1-yuv411p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv411p.avi > +fate-ffv1-dec-v1-yuv420p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv420p.avi > +fate-ffv1-dec-v1-yuv422p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv422p.avi > +fate-ffv1-dec-v1-yuv444p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv444p.avi > +fate-ffv1-dec-v1-yuv440p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuv440p.avi > +# Gray (8bit) > +fate-ffv1-dec-v1-gray: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-gray.avi > +# RGB (8bit) > +fate-ffv1-dec-v1-rgb32: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-rgb32.avi > +# Alpha channel / transparency: > +fate-ffv1-dec-v1-bgra: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-bgra.avi > +fate-ffv1-dec-v1-yuva420p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuva420p.avi > +fate-ffv1-dec-v1-yuva422p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuva422p.avi > +fate-ffv1-dec-v1-yuva444p: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-yuva444p.avi > +# Interlaced: > +fate-ffv1-dec-v1-tff: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-tff.avi > +fate-ffv1-dec-v1-bff: CMD = framecrc -i > $(DEC_SRC)/ffv1-enc-v1-bff.avi trailing whitespace, more below > --- a/tests/fate/lossless-video.mak > +++ b/tests/fate/lossless-video.mak > @@ -48,3 +48,7 @@ fate-zerocodec: CMD = framecrc -i > $(TARGET_SAMPLES)/zerocodec/sample-zeco.avi > > FATE_SAMPLES_AVCONV-$(call DEMDEC, AVI, ZLIB) += fate-zlib > fate-zlib: CMD = framecrc -i $(TARGET_SAMPLES)/lcl/zlib-1frame.avi > + > + > +# FFV1 lossless video codec has more tests, so it's in its own file: > +include $(SRC_PATH)/tests/fate/ffv1.mak Don't include the file from here, include it from tests/Makefile instead. Doesn't look half bad otherwise. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
