My very first patch being reviewed. YAY! :) Thanks for checking it out.
>> --- /dev/null >> +++ b/tests/fate/ffv1.mak >> @@ -0,0 +1,284 @@ >> +# ================================================ >> +# FATE tests for FFV1 lossless video codec >> +# ================================================ > This is unnecessary. Clear. I'm just used to putting such a small header on all my scripts. Habit ;) > Get rid of all the tabs. > trailing whitespace, more below Roger that. Will be fixed. > Don't include the file from here, include it from tests/Makefile instead. Roger that. I thought so too at first, but then considered it a nice-to-have to be able to have a make-target for running all lossless-video FATE tests in one. But I'll put it in tests/Makefile. No problem. I'll update/fix the Makefile and then send the improved patch. Regards, Pb _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
