On Sun, 8 Dec 2013, Sean McGovern wrote:
On Sun, Dec 8, 2013 at 3:50 PM, Martin Storsjö <[email protected]> wrote:
On Wed, 4 Dec 2013, Diego Biurrun wrote:
---
This is running through Oracle right now. I'm quite confident of the
patchset by now.
One thing to note, however, is that -D_XOPEN_SOURCE=600 is no longer
unconditionally added to HOSTCPPFLAGS. This should fix systems like
AIX where this has unwanted side effects, but it might break on systems
that require the flag and should set the flag explicitly.
Unfortunately, this now removes -D_ISOC99_SOURCE and -D_XOPEN_SOURCE=600
from HOSTCPPFLAGS on Solaris. The host tools still build successfully, but
are most likely no longer C99-compliant.
Where does it remove -D_ISOC99_SOURCE? As far as I can see it only removes
the latter.
The host tools don't really exercise much of the C99 standard itself, so
as long as the host libc isn't really weird (like AIX), it shouldn't
really matter as long as it compiles properly. The only thing where it
would matter is for stuff like %z for printfs for hardcoded tables anyway.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
