On Sun, Dec 8, 2013 at 4:34 PM, Diego Biurrun <[email protected]> wrote:
> On Sun, Dec 08, 2013 at 04:29:10PM -0500, Sean McGovern wrote: > > On Sun, Dec 8, 2013 at 3:50 PM, Martin Storsjö <[email protected]> wrote: > > > On Wed, 4 Dec 2013, Diego Biurrun wrote: > > > --- > > >> > > >> This is running through Oracle right now. I'm quite confident of the > > >> patchset by now. > > >> > > >> One thing to note, however, is that -D_XOPEN_SOURCE=600 is no longer > > >> unconditionally added to HOSTCPPFLAGS. This should fix systems like > > >> AIX where this has unwanted side effects, but it might break on > systems > > >> that require the flag and should set the flag explicitly. > > > > > Unfortunately, this now removes -D_ISOC99_SOURCE and -D_XOPEN_SOURCE=600 > > from HOSTCPPFLAGS on Solaris. The host tools still build successfully, > but > > are most likely no longer C99-compliant. > > Huh? > > -host_cppflags='-D_ISOC99_SOURCE -D_XOPEN_SOURCE=600' > +host_cppflags='-D_ISOC99_SOURCE' > > I sure still see -D_ISOC99_SOURCE in my HOSTCPPFLAGS here... > Argh! my bad, you are right... sean@nozomi:/BUILD/libav/gcc.64$ grep HOSTCPPFLAGS config.mak HOSTCPPFLAGS=-D_ISOC99_SOURCE I still think configure should add _XOPEN_SOURCE=600 back. -- Sean McG. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
