On Mon, Jan 13, 2014 at 10:07:44PM +0100, Diego Biurrun wrote:
> On Mon, Jan 13, 2014 at 09:00:39PM +0100, Kostya Shishkov wrote:
> > --- a/libavcodec/dxtory.c
> > +++ b/libavcodec/dxtory.c
[...]
> > +static int dxtory_decode_v2_410(AVCodecContext *avctx, AVFrame *pic,
> > + const uint8_t *src, int src_size)
> > +{
> > +
> > + if (!nslices || avctx->height % nslices) {
> > + avpriv_request_sample(avctx, "%d slices for %dx%d", nslices,
> > + avctx->width, avctx->height);
> > + return AVERROR(ENOSYS);
> > + }
>
> We usually return PATCHESWELCOME after avpriv_request_sample().
Like anyone will submit a patch for this...
> > + slice_height = avctx->height / nslices;
> > + if ((avctx->width & 3) || (slice_height & 3)) {
> > + avpriv_request_sample(avctx, "slice dimensions %dx%d",
> > + avctx->width, slice_height);
> > + }
> > +}
>
> Why no return here?
Because it will decode those files too albeit with some artefacts.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
