On Tue, Jan 14, 2014 at 07:13:29AM +0100, Kostya Shishkov wrote:
> On Mon, Jan 13, 2014 at 10:07:44PM +0100, Diego Biurrun wrote:
> > On Mon, Jan 13, 2014 at 09:00:39PM +0100, Kostya Shishkov wrote:
> > > --- a/libavcodec/dxtory.c
> > > +++ b/libavcodec/dxtory.c
> [...]
> > > +static int dxtory_decode_v2_410(AVCodecContext *avctx, AVFrame *pic,
> > > + const uint8_t *src, int src_size)
> > > +{
> > > +
> > > + if (!nslices || avctx->height % nslices) {
> > > + avpriv_request_sample(avctx, "%d slices for %dx%d", nslices,
> > > + avctx->width, avctx->height);
> > > + return AVERROR(ENOSYS);
> > > + }
> >
> > We usually return PATCHESWELCOME after avpriv_request_sample().
>
> Like anyone will submit a patch for this...
I believe the issue is less about the likelihood of someone submitting
a patch but more about the correctness of the return value...
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
