On 02/07/2014 03:41 PM, Andrew Kelley wrote:
Since 2007, the Xipth.org Foundation recommends that .ogg only be used
for Ogg Vorbis audio files.
typo. it's Xiph.org not Xipth.org
Source: http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions
However we only do it if we have libvorbis available because the
built in vorbis encoder is not very good.
---
libavformat/oggenc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c
index e96cde7..4ad4a48 100644
--- a/libavformat/oggenc.c
+++ b/libavformat/oggenc.c
@@ -616,7 +616,15 @@ AVOutputFormat ff_ogg_muxer = {
.mime_type = "application/ogg",
.extensions = "ogg,ogv,spx,opus",
.priv_data_size = sizeof(OGGContext),
+/*
+ * xiph recommends that .ogg files contain vorbis audio, but our vorbis encoder
+ * is bad enough that we default to flac if we don't have libvorbis.
+ */
+#ifdef CONFIG_LIBVORBIS_ENCODER
+ .audio_codec = AV_CODEC_ID_VORBIS,
+#else
.audio_codec = AV_CODEC_ID_FLAC,
+#endif
.video_codec = AV_CODEC_ID_THEORA,
.write_header = ogg_write_header,
.write_packet = ogg_write_packet,
See how we do this for other muxers (e.g. movenc.c)
.video_codec = CONFIG_LIBVORBIS_ENCODER ? AV_CODEC_ID_VORBIS :
AV_CODEC_ID_FLAC,
and the comment is not needed
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
