On Sun, Feb 9, 2014 at 1:05 AM, Tim Walker <tdskywal...@gmail.com> wrote: > > On 08 Feb 2014, at 18:18, Andrew Kelley <superjo...@gmail.com> wrote: > >> Since 2007, the Xiph.org Foundation recommends that .ogg only be used >> for Ogg Vorbis audio files. >> >> Source: http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions >> >> However we only do it if we have libvorbis available because the >> built in vorbis encoder is not very good. >> --- >> libavformat/oggenc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > I thought the consensus was that the built-in Vorbis encoder was really bad? >
If I understand correctly, libvorbis is the external encoder and the (supposedly bad) internal encoder is built only when the external one is not found. I'm not really keen on having that written in a commit message, but I cannot come up with any better wording. > Either way, LGTM. +1 Vittorio > > Tim > _______________________________________________ > libav-devel mailing list > libav-devel@libav.org > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
