On Tue, Mar 4, 2014 at 10:21 PM, Janne Grunau <[email protected]> wrote:
> On 2014-03-04 19:24:38 +0100, Vittorio Giovara wrote:
>> Also adjust the headers as needed.
>> ---
>> libavcodec/dxva2_h264.c | 1 +
>> libavcodec/dxva2_mpeg2.c | 1 +
>> libavcodec/dxva2_vc1.c | 1 +
>> libavcodec/h264.h | 1 +
>> libavcodec/mpeg12dec.c | 1 +
>> libavcodec/mpegvideo.c | 1 +
>> libavcodec/mpegvideo.h | 10 ----------
>> libavcodec/mpegvideo_enc.c | 1 +
>> libavcodec/mpegvideo_motion.c | 1 +
>> libavcodec/mpegvideo_xvmc.c | 1 +
>> libavcodec/picttype.h | 35 +++++++++++++++++++++++++++++++++++
>> libavcodec/svq1enc.c | 1 +
>> libavcodec/vaapi_h264.c | 1 +
>> libavcodec/vaapi_mpeg2.c | 1 +
>> libavcodec/vdpau_h264.c | 1 +
>> 15 files changed, 48 insertions(+), 10 deletions(-)
>> create mode 100644 libavcodec/picttype.h
>
> The includes look correct but there seems to be many missing relying on
> indirect inclusion through h264.h
>
I've added the various headers in relevant h264_* and svq3 code but I
left the include in h264.h too because of the macro defined there.
>> diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h
>> index 6c3fc42..e125d3b 100644
>> --- a/libavcodec/mpegvideo.h
>> +++ b/libavcodec/mpegvideo.h
>> @@ -85,12 +85,6 @@ enum OutputFormat {
>> #define EXT_START_CODE 0x000001b5
>> #define USER_START_CODE 0x000001b2
>>
>> -/**
>> - * Value of Picture.reference when Picture is not a reference picture, but
>> - * is held for delayed output.
>> - */
>> -#define DELAYED_PIC_REF 4
>> -
>> struct MpegEncContext;
>>
>> /**
>> @@ -640,10 +634,6 @@ typedef struct MpegEncContext {
>> int progressive_sequence;
>> int mpeg_f_code[2][2];
>> int picture_structure;
>
> maybe add a comment that picture_structure holds the defines from
> picttype.h
Added.
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
