On Tue, Mar 4, 2014 at 9:09 PM, Janne Grunau <[email protected]> wrote: > On 2014-03-04 19:24:30 +0100, Vittorio Giovara wrote: >> >> I am working on my branch together with Janne and Luca and we found >> something very shady going on in h264_refs.c and especially in >> COPY_PICTURE macro. > > I wouldn't say it's shady except that it depends on knowing the exact > struct layout of AVFrame. Embedding the struct makes the ref list > handling easier since memory handling is easier. I would prefer to push > this set once it is reviewed and doing the embedded struct to pointer > conversion later. This itself is already a nice improvement. >
Yeah I agree, thanks for the reviews so far. Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
