Hello, with this last set I think I covered most of/all comments received. Notably in this set the headers are correctly propagated, more defines have been put in the new .h files, the commit logs are updated and better described and the ER code has been slighlty simplified.
I think only 4/12 is waiting for a full review. Cheers, Vittorio Vittorio Giovara (12): mpegvideo: directly use frames in ff_draw_horiz_band() h264: directly use frames in ff_h264_draw_horiz_band() er: move relevant fields from Picture to ERPicture h264: move relevant fields from Picture to H264Picture h264: Replace mpegvideo-specific MAX_PICTURE_COUNT by private define h264: Replace mpegvideo-specific MAX_THREADS by private define h264: Remove MotionEstContext and move the relevant fields in H264Context mpegvideo: move PICT_* macros into picttype.h mpegvideo: move MB-related macros and defines to mbtype.h mpegvideo: move ff_draw_horiz_band() in utils.c mpegvideo: remove h264-only fields h264 does not depend on mpegvideo any more configure | 2 +- libavcodec/dxva2_h264.c | 11 ++- libavcodec/dxva2_mpeg2.c | 1 + libavcodec/dxva2_vc1.c | 1 + libavcodec/error_resilience.c | 212 +++++++++++++++++++----------------------- libavcodec/error_resilience.h | 19 +++- libavcodec/h261dec.c | 1 + libavcodec/h261enc.c | 1 + libavcodec/h263.c | 1 + libavcodec/h264.c | 121 +++++++++++++----------- libavcodec/h264.h | 71 +++++++++++--- libavcodec/h264_cabac.c | 2 + libavcodec/h264_cavlc.c | 2 +- libavcodec/h264_direct.c | 11 ++- libavcodec/h264_loopfilter.c | 3 +- libavcodec/h264_mb_template.c | 12 +-- libavcodec/h264_mvpred.h | 2 + libavcodec/h264_parser.c | 1 + libavcodec/h264_ps.c | 2 +- libavcodec/h264_refs.c | 53 +++++------ libavcodec/h264data.h | 1 - libavcodec/internal.h | 7 ++ libavcodec/ituh263dec.c | 1 + libavcodec/ituh263enc.c | 1 + libavcodec/mbtype.h | 97 +++++++++++++++++++ libavcodec/motion_est.c | 1 + libavcodec/mpeg12dec.c | 2 + libavcodec/mpeg4video.c | 1 + libavcodec/mpeg4videodec.c | 1 + libavcodec/mpeg4videoenc.c | 1 + libavcodec/mpegvideo.c | 80 ++++++---------- libavcodec/mpegvideo.h | 98 ++----------------- libavcodec/mpegvideo_enc.c | 2 + libavcodec/mpegvideo_motion.c | 2 + libavcodec/mpegvideo_xvmc.c | 1 + libavcodec/msmpeg4dec.c | 1 + libavcodec/picttype.h | 35 +++++++ libavcodec/ratecontrol.c | 1 + libavcodec/rv30.c | 1 + libavcodec/rv34.c | 1 + libavcodec/rv40.c | 1 + libavcodec/svq1enc.c | 2 + libavcodec/svq3.c | 22 ++--- libavcodec/utils.c | 53 +++++++++++ libavcodec/vaapi_h264.c | 11 ++- libavcodec/vaapi_mpeg2.c | 1 + libavcodec/vc1dec.c | 1 + libavcodec/vdpau_h264.c | 13 +-- libavcodec/wmv2dec.c | 1 + 49 files changed, 571 insertions(+), 398 deletions(-) create mode 100644 libavcodec/mbtype.h create mode 100644 libavcodec/picttype.h -- 1.8.3.4 (Apple Git-47) _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel