On Wed, Mar 19, 2014 at 05:24:27PM +0000, Ben Avison wrote:
> --- a/libavcodec/arm/mlpdsp_init_arm.c
> +++ b/libavcodec/arm/mlpdsp_init_arm.c
> @@ -41,8 +41,72 @@ void ff_mlp_rematrix_channel_arm(int32_t *samples,
> +
> + switch (max_matrix_channel) {
> + case 1: ch_index = 0; break;
> + case 5: ch_index = 1; break;
> + case 7: ch_index = 2; break;
> + default: return ff_mlp_pack_output;
Please break the lines.
> av_cold void ff_mlpdsp_init_arm(MLPDSPContext *c)
> {
> + int cpu_flags = av_get_cpu_flags();
> +
> c->mlp_filter_channel = ff_mlp_filter_channel_arm;
> c->mlp_rematrix_channel = ff_mlp_rematrix_channel_arm;
> + if (cpu_flags & AV_CPU_FLAG_ARMV6)
> + c->mlp_select_pack_output = mlp_select_pack_output_arm;
If the function is specific to ARMv6, it should have an _armv6 suffix,
reside in a separate file and be compiled conditionally.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
