On Wed, Mar 19, 2014 at 05:24:26PM +0000, Ben Avison wrote:
> --- a/libavcodec/mlpdsp.c
> +++ b/libavcodec/mlpdsp.c
> @@ -89,10 +89,46 @@ void ff_mlp_rematrix_channel(int32_t *samples,
> +
> +int32_t ff_mlp_pack_output(int32_t lossless_check_data,
This function is not used outside of the file, so it can be made
static and the ff_ prefix can be removed.
> + int32_t (*sample_buffer)[MAX_CHANNELS],
> + void *data,
> + uint16_t blockpos,
> + uint8_t max_matrix_channel,
> + int is32,
> + uint8_t *ch_assign,
> + int8_t *output_shift)
> +{
> + unsigned int i, out_ch = 0;
> + int32_t *data_32 = (int32_t *)data;
> + int16_t *data_16 = (int16_t *)data;
pointless void* casts
> + lossless_check_data ^= (sample & 0xffffff) << mat_ch;
> + if (is32) *data_32++ = sample << 8;
> + else *data_16++ = sample >> 8;
Please break the lines.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
