On Tue, 25 Mar 2014 15:31:49 +0100
Vittorio Giovara <[email protected]> wrote:


> +
> +    /**
> +     * An AV_PKT_DATA_ROTATION side data packet contains further spatial 
> information
> +     * to be applied to the decoded video.
> +     */
> +    AV_PKT_DATA_DISPLAYORIENTATION,
>  };

Completely lacks documentation in what format the data is. It can be
easily inferred from the rest of the patch, but an API user reading
avcodec.h can't.


> +/**
> + * Spatial transformation information that should be applied to video
> + * after decoding.
> + *
> + * Note that these values are not mutually exclusive.
> + *
> + * The size of this struct is a part of the public ABI.
> + */
> +typedef struct AVDisplayOrientation {
> +    /**
> +     * Video should be orizontally flipped.
> +     */
> +    int hflip;
> +    /**
> +     * Video should be vertically flipped.
> +     */
> +    int vflip;
> +    /**
> +     * Rotation angle to be applied in degrees.
> +     */
> +    int32_t rotation;
> +} AVDisplayOrientation;

So, why not just export the full matrix?
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to