On 03/04/14 11:36, Vittorio Giovara wrote: > On Wed, Apr 2, 2014 at 5:12 PM, wm4 <[email protected]> wrote: >> On Wed, 2 Apr 2014 16:52:20 +0200 >> Vittorio Giovara <[email protected]> wrote: >> >>> On Tue, Mar 25, 2014 at 3:31 PM, Vittorio Giovara >>> <[email protected]> wrote: >>>> Implement exporting rotation angle from mov. >>>> --- >>>> This is redone following more what has been done for replaygain. >>>> Note that showinfo still reports the display orientation data only ONCE, >>>> and I >>>> am not sure if this is the expected behaviour. >>>> Note 2, the hflip and vflip computation are theoretical as I couldn't find >>>> a >>>> sample implementing it, but they still might be useful later on. >>>> It has been requested that an enum might be added to represent simple >>>> tranforms >>>> but I'm not sure if AVDisplayOrientation is the right place to it. >>>> >>>> Cheers, >>>> Vittorio >>>> >>>> Changelog | 1 + >>>> doc/APIchanges | 7 ++++++ >>>> libavcodec/avcodec.h | 6 +++++ >>>> libavcodec/utils.c | 9 +++++++ >>>> libavformat/isom.h | 3 +++ >>>> libavformat/mov.c | 53 >>>> ++++++++++++++++++++++++++++++++++++++++++ >>>> libavutil/Makefile | 1 + >>>> libavutil/displayorientation.h | 47 +++++++++++++++++++++++++++++++++++++ >>>> libavutil/frame.h | 4 ++++ >>>> libavutil/version.h | 2 +- >>>> 10 files changed, 132 insertions(+), 1 deletion(-) >>>> create mode 100644 libavutil/displayorientation.h >>>> >>> Ping. So what should we do with this? >>> Some people want matrix, others want an enum with the transformation, >>> other want just the angle. >>> Also this gets reported at the beginning of the stream only, is that >>> correct? >> >> Export the matrix, add utility functions to extract parameters from it. > > What about HEVC and H264 which have a SEI message for display > orientation but with angle/flip numbers directly, without matrices?
Either we stick with delivering the information in the most (and easiest to derive) common form or we can just make it an opaque and provide accessors that would do the computation to do matrix -> angle or angle -> matrix depending on what the user wants. I'd rather not be so thorough though. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
