On 05/09/2014 04:18 AM, Luca Barbato wrote:
On 09/05/14 09:59, wm4 wrote:
On Mon,  5 May 2014 16:11:33 +0200
Luca Barbato <[email protected]> wrote:

---
  libavresample/avresample.h |  72 +++++++++++++++++++++++++
  libavresample/utils.c      | 128 +++++++++++++++++++++++++++++++++++++++++++++
  libavutil/error.h          |   2 +
  3 files changed, 202 insertions(+)

[...]
Should opts be allowed to be NULL?
Might be a good idea.

Definitely a good idea and would match the lavf and lavc APIs.

IMO there absolutely should be a public function that should check
whether two AVFrames have the same configuration, and/or a function
which checks whether an AVFrame is the same as the current configured
in/out format of the context (like the private config_changed).
The function can be exposed anytime, Justin wanted me to prepare a
commit with the least API increment so I kept it hidden.


I suppose allowing the user to be pro-active and check for changes separately would be fine to add at the same time. We could give both usage examples, checking separately or just handling the return codes.

-Justin


_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to