On 12/05/14 17:31, Justin Ruggles wrote:
> Yeah the latter would be pretty ugly. Basically having to re-convert the
> flushed samples to either the input or the new output format. But all
> the alternatives I can think of are equally ugly...

I guess we can do that on a second iteration as a different function or
using avoption to alter the behaviour (keeping the default the same).

> But if we let the user provide the buffer (not calling get_buffer()
> unconditionally) we should not assume how many samples they want to have
> put in that buffer based on the linesize, which can have padding.

Yes, that's a problem.

> Besides that it just seems simpler to honor nb_samples, and if
> you want the behavior you have in your patch, set nb_samples to 0 before
> calling avresample_convert_frame() if you're reusing an old AVFrame.

I guess it is the best solution.

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to