On Tue, May 27, 2014 at 3:24 AM, Alessandro Ghedini
<[email protected]> wrote:
> Sooo, thanks to Anton I've been able to make this work. I went ahead and split
> the changes in smaller commits (I cherry-picked the commits from ffmpeg
> directly), and while I've been able to squash a few commits together, there
> are
> still 27 separate patches.
Neat, thanks for doing this.
> Now what? I didn't send the patches yet to avoid spamming the list with so
> many
> mails, but I can go ahead and do it if you are ok with it. In any case you can
> see all the commits at [0]. To merge in a local branch do:
I took a look at the set, I only have a few minor suggestions.
- In some commits there are clauses like "Fixes ticket #715." or
requests for comments that may be removed; perhaps this can be done
when we push them.
- The commit message and the error message seem unrelated
7e5261b222fed04523f2bb31557e5f48ff4e1561.
- The commit message does not fully explain the required changes
09ab9e3b43d34776f012d0be3d07913b8e24aaf5 besides claiming that's
better, faster and saves the world from the evil. Perhaps it could be
split in small chunks but I am not sure how... Also I don't get the
removal of { AV_CODEC_ID_GIF, "gif" }.
- I would squash 2804a7617a9339802de70bc8a5d6bca60f909427 onto
/cb03bfba9bfdee67ac40326cd5f18531c1e78fcd
- 8138e09f2c8cd9137f1786f306f786719793895e could use a K&R :)
- I would love to reproduce this
899b56b054681d594c3ea74c6ea44445048bd9b6, also shouldn't the check for
dimensions be in the same place as
b7513e42976e2003cd3eb4e824fa1d60f96c5ba4
- I would squash 9e4b6291397c9a8848129af86f59870fb1230bb6 onto
647d7d41c69083bc0fae11d487a07cb06e2016fa
- 9422d6036079120b1e435e6c711ce9734b0a0995 what issues exactly? Were
you able to reproduce any?
Finally I think it's also fine to remove the micro version bumps that
took place in same changesets.
> There may still be some cleaning work to do. Also, the test (make
> fate-lavf-gif)
> doesn't work yet, I'll need to look into it.
The changesets modified the gif test results, I am not sure if that
has any impact.
Cheers,
--
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
