On Tue, 27 May 2014 09:24:26 +0200, Alessandro Ghedini <[email protected]> wrote: > On mer, mag 07, 2014 at 12:37:41 +0200, Alessandro Ghedini wrote: > > Hi, > > > > I've been working on merging the GIF encoder from ffmpeg, since libav's > > doesn't > > seem to work very well (in my tests anyway), and my initial approach has > > been to > > simply copy/paste lavc/gif.{c,h} and lavf/gif.c, make them compile and see > > how > > it goes (I'm using libav.git). > > Sooo, thanks to Anton I've been able to make this work. I went ahead and split > the changes in smaller commits (I cherry-picked the commits from ffmpeg > directly), and while I've been able to squash a few commits together, there > are > still 27 separate patches. > > Now what? I didn't send the patches yet to avoid spamming the list with so > many > mails, but I can go ahead and do it if you are ok with it.
This is not really a big problem, we've dealt with far larger patchsets in the past. If you've squashed everything that reasonable can/should be (like instances of one commit in the set introducing a bug and another fixing it), then feel free to send the whole branch. > In any case you can > see all the commits at [0]. To merge in a local branch do: > > $ git checkout -b gif > $ git pull https://github.com/ghedo/libav gif > > There may still be some cleaning work to do. Also, the test (make > fate-lavf-gif) > doesn't work yet, I'll need to look into it. > > > Basically, when I'm using ffmpeg (ffmpeg -i test.mkv test.ffmpeg.gif) it > > selects > > "bgr8" and everything goes fine. > > > > > Output #0, gif, to 'test.ffmpeg.gif': > > > Stream #0:0: Video: gif, bgr8, 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, > > > 200 kb/s, 100 tbn, 30 tbc > > > > but when I use avconv, it selects "gray" (which is not what I want): > > > > > Output #0, gif, to 'test.libav.gif': > > > Stream #0.0: Video: gif, gray, 1920x1080 [PAR 1:1 DAR 16:9], q=2-31, > > > 200 kb/s, 100 tbn, 1k tbc > > This still happens, but it's not a big problem for the moment. I hope to get to fixing this properly, but really don't know when I'll have the time. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
