On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote:
> It is doubtful if the hack (still) works and PPC is obsolete for encoding.

not so sure about the latter but xvid had enough time to fix it. no need 
to keep this ugly workaround.

> ---
>  libavcodec/libxvid.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> index eab61be..ddeceac 100644
> --- a/libavcodec/libxvid.c
> +++ b/libavcodec/libxvid.c
> @@ -436,19 +436,7 @@ static av_cold int xvid_encode_init(AVCodecContext 
> *avctx)  {
>  
>      xvid_gbl_init.version = XVID_VERSION;
>      xvid_gbl_init.debug = 0;
> -
> -#if ARCH_PPC
> -    /* Xvid's PPC support is borked, use libavcodec to detect */
> -#if HAVE_ALTIVEC
> -    if (av_get_cpu_flags() & AV_CPU_FLAG_ALTIVEC) {
> -        xvid_gbl_init.cpu_flags = XVID_CPU_FORCE | XVID_CPU_ALTIVEC;
> -    } else
> -#endif
> -        xvid_gbl_init.cpu_flags = XVID_CPU_FORCE;
> -#else
> -    /* Xvid can detect on x86 */
>      xvid_gbl_init.cpu_flags = 0;
> -#endif

xvid_gbl_init is explicitly initialized to zero, so no need to set 
cpu_flags to zero.

otherwise ok

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to