On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote:
> The DCT init code takes care of MMX and other arch details on its own.
yes and no
> ---
> libavcodec/mpeg4videodec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
> index a4e7725..97dbcf6 100644
> --- a/libavcodec/mpeg4videodec.c
> +++ b/libavcodec/mpeg4videodec.c
> @@ -2066,14 +2066,10 @@ static int decode_user_data(Mpeg4DecContext *ctx,
> GetBitContext *gb)
> ctx->divx_build = -1;
> }
>
> -#if HAVE_MMX
> - if (ctx->xvid_build >= 0 &&
> - s->avctx->idct_algo == FF_IDCT_AUTO &&
> - (av_get_cpu_flags() & AV_CPU_FLAG_MMX)) {
> + if (ctx->xvid_build >= 0 && s->avctx->idct_algo == FF_IDCT_AUTO) {
> s->avctx->idct_algo = FF_IDCT_XVIDMMX;
> ff_dct_common_init(s);
> }
> -#endif
that is wrong. It selects arm the unoptimized idct although any idct
implementation was fine as signalled by FF_IDCT_AUTO
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
