On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote:
> On 22/07/14 20:44, Diego Biurrun wrote:
> > --- a/libavformat/http.c
> > +++ b/libavformat/http.c
> > @@ -82,37 +84,38 @@ typedef struct {
> >
> > -#define OFFSET(x) offsetof(HTTPContext, x)
> > -#define D AV_OPT_FLAG_DECODING_PARAM
> > -#define E AV_OPT_FLAG_ENCODING_PARAM
> > +#define OFFSET(x) offsetof(HTTPContext, x)
> > +#define D AV_OPT_FLAG_DECODING_PARAM
> > +#define E AV_OPT_FLAG_ENCODING_PARAM
> > #define DEFAULT_USER_AGENT "Lavf/" AV_STRINGIFY(LIBAVFORMAT_VERSION)
>
> This hunk looks wrong this way, drop it.
Changed.
> > @@ -121,10 +124,11 @@ static int http_connect(URLContext *h, const char
> > *path, const char *local_path,
> >
> > void ff_http_init_auth_state(URLContext *dest, const URLContext *src)
> > {
> > - memcpy(&((HTTPContext*)dest->priv_data)->auth_state,
> > - &((HTTPContext*)src->priv_data)->auth_state,
> > sizeof(HTTPAuthState));
> > - memcpy(&((HTTPContext*)dest->priv_data)->proxy_auth_state,
> > - &((HTTPContext*)src->priv_data)->proxy_auth_state,
> > + memcpy(&((HTTPContext *) dest->priv_data)->auth_state,
> > + &((HTTPContext *) src->priv_data)->auth_state,
> > + sizeof(HTTPAuthState));
> > + memcpy(&((HTTPContext *) dest->priv_data)->proxy_auth_state,
> > + &((HTTPContext *) src->priv_data)->proxy_auth_state,
> > sizeof(HTTPAuthState));
>
> Drop the space between the cast, it is against the coding style.
That is debatable.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
