On 23/07/14 12:59, Diego Biurrun wrote:
> On Wed, Jul 23, 2014 at 12:52:37PM +0200, Luca Barbato wrote:
>> On 23/07/14 12:44, Diego Biurrun wrote:
>>> On Tue, Jul 22, 2014 at 08:53:56PM +0200, Luca Barbato wrote:
>>>> On 22/07/14 20:44, Diego Biurrun wrote:
>>>>> --- a/libavformat/http.c
>>>>> +++ b/libavformat/http.c
>>>>> @@ -121,10 +124,11 @@ static int http_connect(URLContext *h, const char
>>>>> *path, const char *local_path,
>>>>>
>>>>> void ff_http_init_auth_state(URLContext *dest, const URLContext *src)
>>>>> {
>>>>> - memcpy(&((HTTPContext*)dest->priv_data)->auth_state,
>>>>> - &((HTTPContext*)src->priv_data)->auth_state,
>>>>> sizeof(HTTPAuthState));
>>>>> - memcpy(&((HTTPContext*)dest->priv_data)->proxy_auth_state,
>>>>> - &((HTTPContext*)src->priv_data)->proxy_auth_state,
>>>>> + memcpy(&((HTTPContext *) dest->priv_data)->auth_state,
>>>>> + &((HTTPContext *) src->priv_data)->auth_state,
>>>>> + sizeof(HTTPAuthState));
>>>>> + memcpy(&((HTTPContext *) dest->priv_data)->proxy_auth_state,
>>>>> + &((HTTPContext *) src->priv_data)->proxy_auth_state,
>>>>> sizeof(HTTPAuthState));
>>>>
>>>> Drop the space between the cast, it is against the coding style.
>>>
>>> That is debatable.
>>
>> Had been debated: https://wiki.libav.org/CodingStyle/Casts
>
> That is a curious definition of debate.
Had been discussed on irc and then wrote down on the wiki iirc there
were 4 people caring enough to discuss it, you were the only one
suggesting this style.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
