On 26/08/14 14:33, Rémi Denis-Courmont wrote:
> Le 2014-08-24 15:18, Luca Barbato a écrit :
>> Feature matching x11grab.
>> ---
>>  configure                |  11 +
>>  libavdevice/Makefile     |   1 +
>>  libavdevice/alldevices.c |   1 +
>>  libavdevice/xcbgrab.c    | 646
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 659 insertions(+)
>>  create mode 100644 libavdevice/xcbgrab.c
>>
>> diff --git a/configure b/configure
>> index 22b699f..60aa3ca 100755
>> --- a/configure
>> +++ b/configure
>> @@ -213,6 +213,7 @@ External library support:
>>                             native MPEG-4/Xvid encoder exists [no]
>>    --enable-openssl         enable openssl [no]
>>    --enable-x11grab         enable X11 grabbing [no]
>> +  --enable-xcbgrab         enable xcb grabbing [no]
>>    --enable-zlib            enable zlib [autodetect]
>>
>>  Toolchain options:
>> @@ -1172,6 +1173,7 @@ EXTERNAL_LIBRARY_LIST="
>>      libxvid
>>      openssl
>>      x11grab
>> +    xcbgrab
>>      zlib
>>  "
>>
>> @@ -1390,6 +1392,7 @@ HEADERS_LIST="
>>      sys_param_h
>>      sys_resource_h
>>      sys_select_h
>> +    sys_shm_h
>>      sys_soundcard_h
>>      sys_time_h
>>      sys_un_h
>> @@ -2093,6 +2096,7 @@ v4l2_indev_deps_any="linux_videodev2_h
>> sys_videoio_h"
>>  vfwcap_indev_deps="capCreateCaptureWindow vfwcap_defines"
>>  vfwcap_indev_extralibs="-lavicap32"
>>  x11grab_indev_deps="x11grab XShmCreateImage"
>> +xcbgrab_indev_deps="xcbgrab"
>>
>>  # protocols
>>  ffrtmpcrypt_protocol_deps="!librtmp_protocol"
>> @@ -4257,6 +4261,13 @@ require Xext X11/extensions/XShm.h
>> XShmCreateImage -lXext &&
>>  require Xfixes X11/extensions/Xfixes.h XFixesGetCursorImage -lXfixes &&
>>  { enabled xlib || die "ERROR: Xlib not found"; }
>>
>> +enabled xcbgrab &&
>> +require_pkg_config xcb-composite xcb/composite.h
>> xcb_composite_name_window_pixmap &&
> 
> I don't see where you need that.
> 
>> +require_pkg_config xcb-event xcb/xcb_event.h
>> xcb_event_get_error_label &&
> 
> I am not familiar with that one, but I don  see where it's needed either.

They are leftovers from some different (failing) approach at the
problem, thanks for spotting!

> Swapping the two calls above would spare one RTT.

I'll swap them.

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to