On Mon, 08 Sep 2014 17:26:13 +0200 Luca Barbato <[email protected]> wrote:
> On 08/09/14 13:39, Antonio Ospite wrote: > > The code uses XFixes to retrieve the cursor coordinates, but XFixes > > gives no information of what screen the pointer is on; this results in > > always drawing the cursor on the captured screen even if the mouse > > pointer was on another screen. > > > > For example, when capturing from screen 1 (i.e. -f x11grab -i ":0.1") > > the cursor was being drawn in the captured image even when the mouse > > pointer was actually on screen 0, which is wrong and visually confusing. > > Same happens with "follow mouse" I guess, since you have the right setup > could you please tell me how it behaves in that specific case? > You are right, follow_mouse is broken too in multi-screen setups, x11grab always draws the captured screen, even when the cursor is on _another_ screen. I can apply a similar fix to follow_mouse, like in: "don't draw anything when the cursor is on another screen". Having the capture following the mouse when it crosses screens would be a lot more work I guess, but maybe that desn't even make sense. If we say -i ":0.1" we only want screen 1, if we say -i ":0.0" we only want screen 0, and after all even when we say -i ":0", that actually means ":0.0", so it's still screen 0 that we want if we don't specify anything else. > The patch makes sense (pending some editorial work as per > https://wiki.libav.org/GitCommit), thanks a lot. > What is missing? The metadata part? I can add the CC to stable and resend. There is no bug report at bugzilla associated to the issue. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
