On Fri, Oct 17, 2014 at 1:15 PM, Anton Khirnov <[email protected]> wrote: > Quoting Luca Barbato (2014-10-17 13:53:48) >> On 17/10/14 13:49, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2014-10-15 18:32:56) >> >> From: Luca Barbato <[email protected]> >> >> >> >> Spare a branch and make coverity less confused. >> >> >> >> CC: [email protected] >> >> Bug-Id: CID 732222 >> >> --- >> >> libavresample/utils.c | 9 ++++----- >> >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> >> > >> > Yet again -- I'm not a fan of randomly shuffling code around just to >> > make some specific tool shut up. There is a huge number of such tools >> > and each one complains about different perfectly valid code. We cannot >> > appease them all and we should not try. >> > >> >> Makes the code simpler first of all, the fact it makes coverity happier >> is just icing on the cake. >> >> (If coverity is less confused the compiler as well is less confused thus >> usually generating better code) >> > > Well, I do not think it is simpler or better in any way. > > And any performance gains you could possibly gain here are completely > irrelevant.
IMHO this change is small enough that it wouldn't be harmful to have it in. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
